Bug 121231 - Remove RenderApplet.
Summary: Remove RenderApplet.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 09:58 PDT by Andreas Kling
Modified: 2013-09-12 10:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (17.94 KB, patch)
2013-09-12 10:08 PDT, Andreas Kling 		darin: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Lander (18.11 KB, patch)
2013-09-12 10:22 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-12 09:58:38 PDT 
Do we really need a reason?
Comment 1 Andreas Kling 2013-09-12 10:08:36 PDT 
Created attachment 211439 [details]
Patch
Comment 2 Darin Adler 2013-09-12 10:10:13 PDT 
Comment on attachment 211439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211439&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.h:38
>      RenderEmbeddedObject(HTMLFrameOwnerElement*);

Impressed that you were able to resist the urge to change this from * to & in the same patch!
Comment 3 EFL EWS Bot 2013-09-12 10:21:13 PDT 
Comment on attachment 211439 [details]
Patch

Attachment 211439 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1871054
Comment 4 Andreas Kling 2013-09-12 10:22:27 PDT 
Created attachment 211440 [details]
Lander
Comment 5 WebKit Commit Bot 2013-09-12 10:53:44 PDT 
Comment on attachment 211440 [details]
Lander

Clearing flags on attachment: 211440

Committed r155631: <http://trac.webkit.org/changeset/155631>
Comment 6 WebKit Commit Bot 2013-09-12 10:53:47 PDT 
All reviewed patches have been landed.  Closing bug.