Bug 121283 - [CTTE] Tighter element types for RenderSVGInline and subclasses.
Summary: [CTTE] Tighter element types for RenderSVGInline and subclasses.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 02:04 PDT by Andreas Kling
Modified: 2013-09-13 02:47 PDT (History)
14 users (show)

See Also:

Attachments
Patch (17.31 KB, patch)
2013-09-13 02:06 PDT, Andreas Kling 		koivisto: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (17.47 KB, patch)
2013-09-13 02:24 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (17.47 KB, patch)
2013-09-13 02:26 PDT, Andreas Kling 		koivisto: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-13 02:04:40 PDT 
[CTTE] Tighter element types for RenderSVGInline and subclasses.
Comment 1 Andreas Kling 2013-09-13 02:06:08 PDT 
Created attachment 211521 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-13 02:11:07 PDT 
Comment on attachment 211521 [details]
Patch

Attachment 211521 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1868061
Comment 3 EFL EWS Bot 2013-09-13 02:11:21 PDT 
Comment on attachment 211521 [details]
Patch

Attachment 211521 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1895013
Comment 4 EFL EWS Bot 2013-09-13 02:12:19 PDT 
Comment on attachment 211521 [details]
Patch

Attachment 211521 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1883069
Comment 5 Early Warning System Bot 2013-09-13 02:13:15 PDT 
Comment on attachment 211521 [details]
Patch

Attachment 211521 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1895014
Comment 6 Antti Koivisto 2013-09-13 02:17:30 PDT 
Comment on attachment 211521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211521&action=review

> Source/WebCore/rendering/svg/RenderSVGTSpan.h:37
> +    SVGTextPositioningElement& textPositioningElement() const { return static_cast<SVGTextPositioningElement&>(*RenderObject::node()); }

please call the closest base class function instead of node()
Comment 7 Andreas Kling 2013-09-13 02:24:41 PDT 
Created attachment 211522 [details]
Patch
Comment 8 Andreas Kling 2013-09-13 02:26:42 PDT 
Created attachment 211523 [details]
Patch
Comment 9 Early Warning System Bot 2013-09-13 02:30:08 PDT 
Comment on attachment 211523 [details]
Patch

Attachment 211523 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1892119
Comment 10 Antti Koivisto 2013-09-13 02:31:17 PDT 
Comment on attachment 211523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211523&action=review

> Source/WebCore/rendering/svg/RenderSVGTSpan.h:37
> +    SVGTextPositioningElement& textPositioningElement() const { return static_cast<SVGTextPositioningElement&>(RenderSVGInline::graphicsElement()); }

I don't think you need to say RenderSVGInline::
Comment 11 Early Warning System Bot 2013-09-13 02:31:38 PDT 
Comment on attachment 211523 [details]
Patch

Attachment 211523 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1881085
Comment 12 Antti Koivisto 2013-09-13 02:33:12 PDT 
ah WTF_DELETED_FUNCTION nm
Comment 13 Andreas Kling 2013-09-13 02:47:27 PDT 
Committed r155682: <http://trac.webkit.org/changeset/155682>