Bug 121288 - Remove support for anonymous deprecated flexboxes.
Summary: Remove support for anonymous deprecated flexboxes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 03:44 PDT by Andreas Kling
Modified: 2013-09-13 05:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.59 KB, patch)
2013-09-13 03:59 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-13 03:44:02 PDT 
Looks like this is not needed anymore.
Comment 1 Andreas Kling 2013-09-13 03:59:14 PDT 
Created attachment 211533 [details]
Patch
Comment 2 Antti Koivisto 2013-09-13 04:03:02 PDT 
Nice!
Comment 3 Antti Koivisto 2013-09-13 04:04:01 PDT 
Comment on attachment 211533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211533&action=review

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:-135
> -            FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChrome);
> -        else if (url.protocolIs("chrome-extension"))
> -            FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxChromeExtension);
> -        else
> -            FeatureObserver::observe(&document(), FeatureObserver::DeprecatedFlexboxWebContent);

I guess we can nuke those FeatureObserver enum values too.
Comment 4 Andreas Kling 2013-09-13 05:21:33 PDT 
Comment on attachment 211533 [details]
Patch

Clearing flags on attachment: 211533

Committed r155689: <http://trac.webkit.org/changeset/155689>
Comment 5 Andreas Kling 2013-09-13 05:21:38 PDT 
All reviewed patches have been landed.  Closing bug.