Bug 121345 - CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Summary: CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 22:38 PDT by Andreas Kling
Modified: 2013-09-13 23:30 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.00 KB, patch)
2013-09-13 22:40 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-13 22:38:20 PDT 
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Comment 1 Andreas Kling 2013-09-13 22:40:13 PDT 
Created attachment 211622 [details]
Patch
Comment 2 Brent Fulgham 2013-09-13 23:03:20 PDT 
Comment on attachment 211622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211622&action=review

r=me. I had question about the "renderName" method, but otherwise it looks good to me.

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:38
> +    explicit RenderSVGResourceMarker(SVGMarkerElement&);

Yes!

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:-41
> -    virtual const char* renderName() const { return "RenderSVGResourceMarker"; }

Is this stuff not needed for printing render tree dumps?
Comment 3 Andreas Kling 2013-09-13 23:30:27 PDT 
Comment on attachment 211622 [details]
Patch

Clearing flags on attachment: 211622

Committed r155750: <http://trac.webkit.org/changeset/155750>
Comment 4 Andreas Kling 2013-09-13 23:30:33 PDT 
All reviewed patches have been landed.  Closing bug.