Bug 121551 - Remove port-specific test expectations that were identical to generic expectations.
Summary: Remove port-specific test expectations that were identical to generic expecta...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 06:26 PDT by Andreas Kling
Modified: 2014-02-03 02:10 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.36 MB, patch)
2013-09-18 06:28 PDT, Andreas Kling 		koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-18 06:26:15 PDT 
Remove port-specific test expectations that were identical to generic expectations.
Comment 1 Andreas Kling 2013-09-18 06:28:22 PDT 
Created attachment 211990 [details]
Patch
Comment 2 Antti Koivisto 2013-09-18 06:35:57 PDT 
Comment on attachment 211990 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2013-09-18 07:53:50 PDT 
Comment on attachment 211990 [details]
Patch

Rejecting attachment 211990 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 211990, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patching file LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt
rm 'LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt'
patching file LayoutTests/platform/win/svg/custom/pattern-scaling-expected.txt
rm 'LayoutTests/platform/win/svg/custom/pattern-scaling-expected.txt'

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/1888274
Comment 4 WebKit Commit Bot 2013-09-18 08:22:36 PDT 
Comment on attachment 211990 [details]
Patch

Rejecting attachment 211990 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 211990, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patching file LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt
rm 'LayoutTests/platform/win/plugins/npp-set-window-called-during-destruction-expected.txt'
patching file LayoutTests/platform/win/svg/custom/pattern-scaling-expected.txt
rm 'LayoutTests/platform/win/svg/custom/pattern-scaling-expected.txt'

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/1927272
Comment 5 Andreas Kling 2013-10-16 01:12:24 PDT 
Committed r157497: <http://trac.webkit.org/changeset/157497>
Comment 6 Andreas Kling 2013-10-16 01:23:43 PDT 
Committed r157498: <http://trac.webkit.org/changeset/157498>
Comment 7 Andreas Kling 2013-10-16 01:34:00 PDT 
Committed r157499: <http://trac.webkit.org/changeset/157499>
Comment 8 Andreas Kling 2013-10-16 01:41:21 PDT 
Committed r157501: <http://trac.webkit.org/changeset/157501>
Comment 9 Andreas Kling 2013-10-16 01:49:53 PDT 
Committed r157503: <http://trac.webkit.org/changeset/157503>
Comment 10 Andreas Kling 2013-10-16 03:28:07 PDT 
Reverted r157497 for reason:

Sigh. This wasn't wrong either.

Committed r157511: <http://trac.webkit.org/changeset/157511>