Bug 121627 - Optimize fetching the Node for never-anonymous renderers.
Summary: Optimize fetching the Node for never-anonymous renderers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 12:21 PDT by Andreas Kling
Modified: 2013-09-20 05:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch idea (24.68 KB, patch)
2013-09-19 12:23 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
To land (29.54 KB, patch)
2013-09-20 04:45 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-19 12:21:54 PDT
Optimize fetching the Node for never-anonymous renderers.
Comment 1 Andreas Kling 2013-09-19 12:23:04 PDT
Created attachment 212088 [details]
Patch idea
Comment 2 Antti Koivisto 2013-09-19 12:27:32 PDT
Comment on attachment 212088 [details]
Patch idea

View in context: https://bugs.webkit.org/attachment.cgi?id=212088&action=review

> Source/WebCore/rendering/RenderObject.h:1008
> +    Node* nodeInternal() const { ASSERT(!isAnonymous()); return m_node; }

node/elementForNonAnonymous()?
Comment 3 Antti Koivisto 2013-09-19 12:27:46 PDT
Comment on attachment 212088 [details]
Patch idea

Cool idea
Comment 4 Andreas Kling 2013-09-20 04:45:12 PDT
Created attachment 212150 [details]
To land
Comment 5 WebKit Commit Bot 2013-09-20 05:15:09 PDT
Comment on attachment 212150 [details]
To land

Clearing flags on attachment: 212150

Committed r156155: <http://trac.webkit.org/changeset/156155>
Comment 6 WebKit Commit Bot 2013-09-20 05:15:11 PDT
All reviewed patches have been landed.  Closing bug.