Bug 121845 - Make hoverAncestor() a RenderElement concept.
Summary: Make hoverAncestor() a RenderElement concept.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 09:59 PDT by Andreas Kling
Modified: 2013-09-24 10:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.77 KB, patch)
2013-09-24 10:04 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
For landing (15.14 KB, patch)
2013-09-24 10:12 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (13.94 KB, patch)
2013-09-24 10:22 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (14.62 KB, patch)
2013-09-24 10:30 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-24 09:59:08 PDT 
Make hoverAncestor() a RenderElement concept.
Comment 1 Andreas Kling 2013-09-24 10:04:50 PDT 
Created attachment 212475 [details]
Patch
Comment 2 Antti Koivisto 2013-09-24 10:07:41 PDT 
Comment on attachment 212475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212475&action=review

> Source/WebCore/rendering/RenderElement.cpp:951
> +                hoverAncestor = toRenderElement(domAncestorNode->renderer());

I guess we really should make ContainerNode::renderer() return RenderElement.
Comment 3 Andreas Kling 2013-09-24 10:12:00 PDT 
Created attachment 212476 [details]
For landing
Comment 4 Andreas Kling 2013-09-24 10:22:10 PDT 
Created attachment 212478 [details]
Patch for landing
Comment 5 Andreas Kling 2013-09-24 10:30:50 PDT 
Created attachment 212479 [details]
Patch for landing

Why is this so hard.
Comment 6 WebKit Commit Bot 2013-09-24 10:50:07 PDT 
Comment on attachment 212479 [details]
Patch for landing

Clearing flags on attachment: 212479

Committed r156338: <http://trac.webkit.org/changeset/156338>
Comment 7 WebKit Commit Bot 2013-09-24 10:50:10 PDT 
All reviewed patches have been landed.  Closing bug.