Bug 121890 - Remove EventPathWalker.
Summary: Remove EventPathWalker.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 19:19 PDT by Andreas Kling
Modified: 2013-09-25 06:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch for bots (11.39 KB, patch)
2013-09-24 19:19 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (462.85 KB, application/zip)
2013-09-24 20:07 PDT, Build Bot 		no flags Details
Patch for bots (11.60 KB, patch)
2013-09-24 20:23 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (12.97 KB, patch)
2013-09-25 05:26 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (19.33 KB, patch)
2013-09-25 05:27 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-24 19:19:01 PDT 
Let's lose some more Shadow DOM gunk.
Comment 1 Andreas Kling 2013-09-24 19:19:32 PDT 
Created attachment 212531 [details]
Patch for bots
Comment 2 WebKit Commit Bot 2013-09-24 19:20:32 PDT 
Attachment 212531 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventPathWalker.cpp', u'Source/WebCore/dom/EventPathWalker.h', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/page/EventHandler.cpp']" exit_code: 1
Source/WebCore/dom/EventPathWalker.cpp:1:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebCore/dom/EventPathWalker.h:1:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-09-24 20:07:43 PDT 
Comment on attachment 212531 [details]
Patch for bots

Attachment 212531 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2233008

New failing tests:
fast/css-generated-content/pseudo-transition-event.html
Comment 4 Build Bot 2013-09-24 20:07:45 PDT 
Created attachment 212533 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Andreas Kling 2013-09-24 20:23:57 PDT 
Created attachment 212534 [details]
Patch for bots

Fix pseudo element events.
Comment 6 WebKit Commit Bot 2013-09-24 20:53:22 PDT 
Attachment 212534 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventPathWalker.cpp', u'Source/WebCore/dom/EventPathWalker.h', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/page/EventHandler.cpp']" exit_code: 1
Source/WebCore/dom/EventPathWalker.cpp:1:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebCore/dom/EventPathWalker.h:1:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Antti Koivisto 2013-09-24 21:26:35 PDT 
Comment on attachment 212534 [details]
Patch for bots

View in context: https://bugs.webkit.org/attachment.cgi?id=212534&action=review

> Source/WebCore/dom/EventRetargeter.cpp:77
> +static Node* nodeOrHostIfPseudoPseudoElement(Node* node)

Needs more Pseudo.
Comment 8 Andreas Kling 2013-09-25 05:26:00 PDT 
Created attachment 212561 [details]
Patch
Comment 9 Andreas Kling 2013-09-25 05:27:57 PDT 
Created attachment 212562 [details]
Patch

With build systems.
Comment 10 WebKit Commit Bot 2013-09-25 06:01:11 PDT 
Comment on attachment 212562 [details]
Patch

Clearing flags on attachment: 212562

Committed r156390: <http://trac.webkit.org/changeset/156390>
Comment 11 WebKit Commit Bot 2013-09-25 06:01:15 PDT 
All reviewed patches have been landed.  Closing bug.