Bug 122438 - rangeOfContents() should take a Node&.
Summary: rangeOfContents() should take a Node&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-06 20:51 PDT by Andreas Kling
Modified: 2013-10-10 03:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.30 KB, patch)
2013-10-06 20:51 PDT, Andreas Kling 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-06 20:51:33 PDT 
This function is never called with a null Node*.
Comment 1 Andreas Kling 2013-10-06 20:51:56 PDT 
Created attachment 213560 [details]
Patch
Comment 2 Build Bot 2013-10-06 22:38:29 PDT 
Comment on attachment 213560 [details]
Patch

Attachment 213560 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3560029
Comment 3 Darin Adler 2013-10-07 10:36:23 PDT 
Comment on attachment 213560 [details]
Patch

r=me, but fix Windows

     1>..\..\win\WebFrame.cpp(1935): error C2664: 'WebCore::rangeOfContents' : cannot convert parameter 1 from 'WebCore::Document *' to 'WebCore::Node &'
Comment 4 Andreas Kling 2013-10-10 03:47:59 PDT 
Committed r157212: <http://trac.webkit.org/changeset/157212>