Bug 122752 - Pass Document directly to anonymous renderer constructors.
Summary: Pass Document directly to anonymous renderer constructors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-14 07:14 PDT by Andreas Kling
Modified: 2013-10-14 10:54 PDT (History)
3 users (show)

See Also:


Attachments
For EWS (120.37 KB, patch)
2013-10-14 07:15 PDT, Andreas Kling
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (190.51 KB, application/zip)
2013-10-14 08:18 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (190.20 KB, application/zip)
2013-10-14 08:59 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (190.63 KB, application/zip)
2013-10-14 09:25 PDT, Build Bot
no flags Details
Patch (140.62 KB, patch)
2013-10-14 10:07 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-14 07:14:35 PDT
Instead of calling setDocumentForAnonymous() after creating a renderer, we should pass the Document directly to the constructor.
Comment 1 Andreas Kling 2013-10-14 07:15:10 PDT
Created attachment 214151 [details]
For EWS
Comment 2 Build Bot 2013-10-14 08:18:49 PDT
Comment on attachment 214151 [details]
For EWS

Attachment 214151 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4022053

New failing tests:
http/tests/appcache/main-resource-hash.html
css1/text_properties/line_height.html
compositing/plugins/1x1-composited-plugin.html
compositing/color-matching/pdf-image-match.html
compositing/masks/multiple-masks.html
compositing/overflow/ancestor-overflow.html
compositing/overflow/overflow-compositing-descendant.html
css2.1/20110323/abspos-containing-block-initial-004d.htm
css2.1/20110323/abspos-containing-block-initial-004f.htm
compositing/masks/simple-composited-mask.html
css1/pseudo/firstletter.html
css1/cascade/cascade_order.html
css1/pseudo/multiple_pseudo_elements.html
compositing/webgl/webgl-background-color.html
css2.1/20110323/abspos-containing-block-initial-004e.htm
compositing/shadows/shadow-drawing.html
compositing/plugins/no-backing-store.html
compositing/overflow/overflow-scroll.html
css1/basic/contextual_selectors.html
compositing/geometry/clipping-foreground.html
http/tests/appcache/offline-access.html
compositing/webgl/webgl-reflection.html
css2.1/20110323/abspos-containing-block-initial-004c.htm
css1/pseudo/anchor.html
compositing/masks/masked-ancestor.html
compositing/masks/direct-image-mask.html
compositing/overflow/nested-scrolling.html
css1/classification/display.html
compositing/overflow/parent-overflow.html
compositing/reflections/simple-composited-reflections.html
Comment 3 Build Bot 2013-10-14 08:18:51 PDT
Created attachment 214153 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2013-10-14 08:59:36 PDT
Comment on attachment 214151 [details]
For EWS

Attachment 214151 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3474104

New failing tests:
http/tests/appcache/main-resource-hash.html
css1/text_properties/line_height.html
compositing/plugins/1x1-composited-plugin.html
compositing/color-matching/pdf-image-match.html
compositing/masks/multiple-masks.html
compositing/overflow/ancestor-overflow.html
compositing/overflow/overflow-compositing-descendant.html
css2.1/20110323/abspos-containing-block-initial-004d.htm
css2.1/20110323/abspos-containing-block-initial-004f.htm
compositing/masks/simple-composited-mask.html
css1/pseudo/firstletter.html
css1/cascade/cascade_order.html
css1/pseudo/multiple_pseudo_elements.html
compositing/webgl/webgl-background-color.html
css2.1/20110323/abspos-containing-block-initial-004e.htm
compositing/shadows/shadow-drawing.html
compositing/plugins/no-backing-store.html
compositing/overflow/overflow-scroll.html
css1/basic/contextual_selectors.html
compositing/geometry/clipping-foreground.html
http/tests/appcache/offline-access.html
compositing/webgl/webgl-reflection.html
css2.1/20110323/abspos-containing-block-initial-004c.htm
css1/pseudo/anchor.html
compositing/masks/masked-ancestor.html
compositing/masks/direct-image-mask.html
compositing/overflow/nested-scrolling.html
css1/classification/display.html
compositing/overflow/parent-overflow.html
compositing/reflections/simple-composited-reflections.html
Comment 5 Build Bot 2013-10-14 08:59:37 PDT
Created attachment 214154 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2013-10-14 09:25:02 PDT
Comment on attachment 214151 [details]
For EWS

Attachment 214151 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3405063

New failing tests:
http/tests/appcache/main-resource-hash.html
css1/text_properties/line_height.html
compositing/plugins/1x1-composited-plugin.html
compositing/color-matching/pdf-image-match.html
compositing/masks/multiple-masks.html
compositing/overflow/ancestor-overflow.html
compositing/overflow/overflow-compositing-descendant.html
css2.1/20110323/abspos-containing-block-initial-004d.htm
css2.1/20110323/abspos-containing-block-initial-004f.htm
compositing/masks/simple-composited-mask.html
css1/pseudo/firstletter.html
css1/cascade/cascade_order.html
css1/pseudo/multiple_pseudo_elements.html
compositing/webgl/webgl-background-color.html
css2.1/20110323/abspos-containing-block-initial-004e.htm
compositing/shadows/shadow-drawing.html
compositing/plugins/no-backing-store.html
compositing/overflow/overflow-scroll.html
css1/basic/contextual_selectors.html
compositing/geometry/clipping-foreground.html
http/tests/appcache/offline-access.html
compositing/webgl/webgl-reflection.html
css2.1/20110323/abspos-containing-block-initial-004c.htm
css1/pseudo/anchor.html
compositing/masks/masked-ancestor.html
compositing/masks/direct-image-mask.html
compositing/overflow/nested-scrolling.html
css1/classification/display.html
compositing/overflow/parent-overflow.html
compositing/reflections/simple-composited-reflections.html
Comment 7 Build Bot 2013-10-14 09:25:03 PDT
Created attachment 214156 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Andreas Kling 2013-10-14 10:07:01 PDT
Created attachment 214159 [details]
Patch
Comment 9 Antti Koivisto 2013-10-14 10:19:48 PDT
Comment on attachment 214159 [details]
Patch

These duplicated complex constructors are pretty appalling. Hope we'll get delegating constructors soon.
Comment 10 Andreas Kling 2013-10-14 10:54:28 PDT
Committed r157408: <http://trac.webkit.org/changeset/157408>