Bug 122820 - Tighten animation-driven restyle to operate on Element only.
Summary: Tighten animation-driven restyle to operate on Element only.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-15 01:29 PDT by Andreas Kling
Modified: 2013-10-23 03:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.69 KB, patch)
2013-10-15 01:30 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (8.02 KB, patch)
2013-10-17 14:15 PDT, Andreas Kling 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-15 01:29:44 PDT 
Tighten animation-driven restyle to operate on Element only.
Comment 1 Andreas Kling 2013-10-15 01:30:35 PDT 
Created attachment 214242 [details]
Patch
Comment 2 Antti Koivisto 2013-10-15 04:08:01 PDT 
Comment on attachment 214242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214242&action=review

> Source/WebCore/page/animation/AnimationControllerPrivate.h:73
> -    void addNodeChangeToDispatch(PassRefPtr<Node>);
> +    void addElementChangeToDispatch(Element*);

The function does take ownership so I think PassRefPtr argument would still be appropriate.
Comment 3 Andreas Kling 2013-10-17 14:15:06 PDT 
Created attachment 214507 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-10-22 06:02:26 PDT 
Comment on attachment 214507 [details]
Patch for landing

Rejecting attachment 214507 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 214507, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 3 hunks FAILED -- saving rejects to file Source/WebCore/page/animation/AnimationController.cpp.rej
patching file Source/WebCore/page/animation/AnimationController.h
patching file Source/WebCore/page/animation/AnimationControllerPrivate.h
Hunk #3 FAILED at 133.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/page/animation/AnimationControllerPrivate.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/8788310
Comment 5 Andreas Kling 2013-10-23 03:54:15 PDT 
Committed r157856: <http://trac.webkit.org/changeset/157856>