Bug 123203 - Make more StringImpl construction functions return PassRef.
Summary: Make more StringImpl construction functions return PassRef.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 06:12 PDT by Andreas Kling
Modified: 2013-10-23 12:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.88 KB, patch)
2013-10-23 06:13 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-23 06:12:20 PDT 
Patch ahoy.
Comment 1 Andreas Kling 2013-10-23 06:13:46 PDT 
Created attachment 214950 [details]
Patch
Comment 2 Antti Koivisto 2013-10-23 06:40:31 PDT 
Comment on attachment 214950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214950&action=review

> Source/WTF/wtf/text/AtomicString.cpp:134
>      static void translate(StringImpl*& location, const UCharBuffer& buf, unsigned hash)

Can these just return PassRef<StringImpl>?
Comment 3 WebKit Commit Bot 2013-10-23 12:11:56 PDT 
Comment on attachment 214950 [details]
Patch

Clearing flags on attachment: 214950

Committed r157877: <http://trac.webkit.org/changeset/157877>
Comment 4 WebKit Commit Bot 2013-10-23 12:11:58 PDT 
All reviewed patches have been landed.  Closing bug.