Bug 123210 - [CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with multiple regions
Summary: [CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowTh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 10:33 PDT by Zoltan Horvath
Modified: 2013-10-25 10:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.32 KB, patch)
2013-10-23 10:40 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-10-23 10:33:35 PDT 
I simplified the determining of the next region part of updateShapeAndSegmentsForCurrentLineInFlowThread's implementation in order to make the code more straightforward.
I also tried to avoid using regionAtBlockOffset(...) function as possible, since it's always that reliable, what I'll will report in a separate bug.
Comment 1 Zoltan Horvath 2013-10-23 10:40:25 PDT 
Created attachment 214974 [details]
Patch
Comment 2 Dave Hyatt 2013-10-25 09:57:27 PDT 
Comment on attachment 214974 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-25 10:25:59 PDT 
Comment on attachment 214974 [details]
Patch

Clearing flags on attachment: 214974

Committed r158016: <http://trac.webkit.org/changeset/158016>
Comment 4 WebKit Commit Bot 2013-10-25 10:26:01 PDT 
All reviewed patches have been landed.  Closing bug.