Bug 123294 - Uncomplicate some of SVGTextRunRenderingContext.
Summary: Uncomplicate some of SVGTextRunRenderingContext.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 15:31 PDT by Andreas Kling
Modified: 2013-10-24 16:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.99 KB, patch)
2013-10-24 15:33 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-24 15:31:54 PDT 
Patch forthcoming.
Comment 1 Andreas Kling 2013-10-24 15:33:24 PDT 
Created attachment 215112 [details]
Patch
Comment 2 Antti Koivisto 2013-10-24 15:39:59 PDT 
Comment on attachment 215112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215112&action=review

> Source/WebCore/ChangeLog:10
> +        - Constructor now takes a RenderObject&.

RenderObject :(

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:56
> -static inline RenderObject* firstParentRendererForNonTextNode(RenderObject* renderer)
> +static inline RenderElement& firstParentRendererForNonTextNode(RenderObject& renderer)

The name is totally misleading.

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:59
> +    if (renderer.isText()) {
> +        ASSERT(renderer.parent());

Text renderers always have parent. The assert doesn't add anything.
Comment 3 Andreas Kling 2013-10-24 16:33:50 PDT 
Committed r157960: <http://trac.webkit.org/changeset/157960>