Bug 123392 - Re-use existing RenderStyle local in textWidth().
Summary: Re-use existing RenderStyle local in textWidth().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-26 13:53 PDT by Andreas Kling
Modified: 2013-11-01 18:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2013-10-26 13:54 PDT, Andreas Kling
koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-26 13:53:32 PDT
From the Saturday Micro-Optimization Department.
Comment 1 Andreas Kling 2013-10-26 13:54:09 PDT
Created attachment 215259 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-29 12:42:18 PDT
Comment on attachment 215259 [details]
Patch

Rejecting attachment 215259 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 215259, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp
Hunk #1 FAILED at 2388.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/16968039
Comment 3 Andreas Kling 2013-11-01 18:48:36 PDT
Committed r158476: <http://trac.webkit.org/changeset/158476>