Bug 123721 - HTMLTableRowsCollection is always rooted at a HTMLTableElement.
Summary: HTMLTableRowsCollection is always rooted at a HTMLTableElement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-04 00:14 PST by Andreas Kling
Modified: 2013-11-04 00:52 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.53 KB, patch)
2013-11-04 00:14 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-04 00:14:02 PST
HTMLTableRowsCollection is always rooted at a HTMLTableElement.
Comment 1 Andreas Kling 2013-11-04 00:14:28 PST
Created attachment 215893 [details]
Patch
Comment 2 Antti Koivisto 2013-11-04 00:35:27 PST
Comment on attachment 215893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215893&action=review

> Source/WebCore/html/HTMLTableRowsCollection.cpp:164
> +    return rowAfter(&const_cast<HTMLTableElement&>(tableElement()), toHTMLTableRowElement(previous));

I like putting & or * inside the cast and casting to the final type.
Comment 3 Andreas Kling 2013-11-04 00:52:05 PST
Committed r158564: <http://trac.webkit.org/changeset/158564>