RESOLVED FIXED 123728
CSSPrimitiveValue color constructors should return PassRef.
https://bugs.webkit.org/show_bug.cgi?id=123728
Summary CSSPrimitiveValue color constructors should return PassRef.
Andreas Kling
Reported Monday, November 4, 2013 10:11:26 AM UTC
CSSPrimitiveValue color constructors should return PassRef.
Attachments
Patch (5.31 KB, patch)
2013-11-04 02:11 PST, Andreas Kling
no flags
Andreas Kling
Comment 1 Monday, November 4, 2013 10:11:53 AM UTC
Antti Koivisto
Comment 2 Monday, November 4, 2013 11:53:24 AM UTC
Comment on attachment 215900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215900&action=review > Source/WebCore/css/CSSValuePool.cpp:82 > - // Just wipe out the cache and start rebuilding if it gets too big. > + // Remove one entry at random if the cache grows too large. > const int maximumColorCacheSize = 512; > - if (m_colorValueCache.size() > maximumColorCacheSize) > - m_colorValueCache.clear(); > + if (m_colorValueCache.size() >= maximumColorCacheSize) > + m_colorValueCache.remove(m_colorValueCache.begin()); Maybe the bug title should really be about this.
WebKit Commit Bot
Comment 3 Monday, November 4, 2013 12:59:46 PM UTC
Comment on attachment 215900 [details] Patch Clearing flags on attachment: 215900 Committed r158573: <http://trac.webkit.org/changeset/158573>
WebKit Commit Bot
Comment 4 Monday, November 4, 2013 12:59:48 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.