Bug 123882 - Add InlineElementBox and stop instantiating InlineBox directly.
Summary: Add InlineElementBox and stop instantiating InlineBox directly.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 01:41 PST by Andreas Kling
Modified: 2013-11-06 02:25 PST (History)
8 users (show)

See Also:

Attachments
Patch (23.85 KB, patch)
2013-11-06 01:50 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-06 01:41:57 PST 
Add InlineElementBox and stop instantiating InlineBox directly.
Comment 1 Andreas Kling 2013-11-06 01:50:23 PST 
Created attachment 216155 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-06 01:52:56 PST 
Attachment 216155 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/EllipsisBox.h', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineElementBox.cpp', u'Source/WebCore/rendering/InlineElementBox.h', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp']" exit_code: 1
Source/WebCore/rendering/InlineBox.h:376:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineElementBox.cpp:63:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2013-11-06 02:11:43 PST 
Comment on attachment 216155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216155&action=review

> Source/WebCore/rendering/InlineFlowBox.h:41
> -class InlineFlowBox : public InlineBox {
> +class InlineFlowBox : public InlineElementBox {

I'm not sure if this inheritance is useful. Is there some useful code sharing possible with this?
Comment 4 Andreas Kling 2013-11-06 02:25:17 PST 
Committed r158736: <http://trac.webkit.org/changeset/158736>