Bug 123980 - Use tighter InlineBox subtypes in some places.
Summary: Use tighter InlineBox subtypes in some places.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 02:53 PST by Andreas Kling
Modified: 2013-11-07 04:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (14.12 KB, patch)
2013-11-07 02:58 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-07 02:53:44 PST 
moar tight
Comment 1 Andreas Kling 2013-11-07 02:58:02 PST 
Created attachment 216280 [details]
Patch
Comment 2 Antti Koivisto 2013-11-07 03:01:13 PST 
Comment on attachment 216280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216280&action=review

> Source/WebCore/rendering/RenderBox.cpp:1984
> +        box.removeFromParent();
> +        delete &box;

Maybe box.removeFromParent() should return a unique_ptr.
Comment 3 WebKit Commit Bot 2013-11-07 04:02:06 PST 
Comment on attachment 216280 [details]
Patch

Clearing flags on attachment: 216280

Committed r158842: <http://trac.webkit.org/changeset/158842>
Comment 4 WebKit Commit Bot 2013-11-07 04:02:09 PST 
All reviewed patches have been landed.  Closing bug.