WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123980
Use tighter InlineBox subtypes in some places.
https://bugs.webkit.org/show_bug.cgi?id=123980
Summary
Use tighter InlineBox subtypes in some places.
Andreas Kling
Reported
2013-11-07 02:53:44 PST
moar tight
Attachments
Patch
(14.12 KB, patch)
2013-11-07 02:58 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-11-07 02:58:02 PST
Created
attachment 216280
[details]
Patch
Antti Koivisto
Comment 2
2013-11-07 03:01:13 PST
Comment on
attachment 216280
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=216280&action=review
> Source/WebCore/rendering/RenderBox.cpp:1984 > + box.removeFromParent(); > + delete &box;
Maybe box.removeFromParent() should return a unique_ptr.
WebKit Commit Bot
Comment 3
2013-11-07 04:02:06 PST
Comment on
attachment 216280
[details]
Patch Clearing flags on attachment: 216280 Committed
r158842
: <
http://trac.webkit.org/changeset/158842
>
WebKit Commit Bot
Comment 4
2013-11-07 04:02:09 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug