Bug 124111 - Move MathML type checking virtuals to RenderObject.
Summary: Move MathML type checking virtuals to RenderObject.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-09 20:34 PST by Andreas Kling
Modified: 2013-11-09 21:06 PST (History)
16 users (show)

See Also:

Attachments
Patch (19.32 KB, patch)
2013-11-09 20:38 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (19.32 KB, patch)
2013-11-09 20:45 PST, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-09 20:34:25 PST 
You currently have to cast renderers to RenderMathMLBlock before you can do further type checking.
We should move all those isRenderMathMLFoo() functions to RenderObject.
Comment 1 Andreas Kling 2013-11-09 20:38:18 PST 
Created attachment 216508 [details]
Patch
Comment 2 Andreas Kling 2013-11-09 20:45:13 PST 
Created attachment 216509 [details]
Patch

Oops, first patch broke accessibility/mathml-elements.html
Comment 3 Andreas Kling 2013-11-09 21:06:49 PST 
Committed r159009: <http://trac.webkit.org/changeset/159009>