Bug 124121 - CSS direction must be reset to ltr on <math> element.
Summary: CSS direction must be reset to ltr on <math> element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL: https://developer.mozilla.org/he/docs...
Keywords: WebExposed
Depends on:
Blocks: 123018
  Show dependency tree / graph
 
Reported: 2013-11-10 01:52 PST by Frédéric Wang (:fredw)
Modified: 2014-03-10 12:26 PDT (History)
10 users (show)

See Also:

Attachments
screeshot (137.53 KB, image/png)
2013-11-10 01:52 PST, Frédéric Wang (:fredw) 		no flags Details
Patch V1 (2.75 KB, patch)
2013-11-10 03:58 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2013-11-10 01:52:36 PST 
Created attachment 216520 [details]
screeshot

See https://developer.mozilla.org/he/docs/Mozilla_MathML_Project/Start and attachment.

The text is in Hebrew, so the CSS direction is RTL. However, mathematical formulas are written LTR in Hebrew, so the CSS RTL direction must not be inherited. This can be trivially fixed by resetting the direction on the <math> element:

math { direction: ltr; }
Comment 1 Frédéric Wang (:fredw) 2013-11-10 03:58:49 PST 
Created attachment 216523 [details]
Patch V1
Comment 2 Darin Adler 2013-11-10 17:32:20 PST 
Comment on attachment 216523 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=216523&action=review

> Source/WebCore/css/mathml.css:6
> +    direction: ltr;

Looks like this style will also be visible in computed style, not just in how the text is displayed. It would be good to add a test that covers that as well. Could easily add that to the direction test simply by writing a little code to extract the computed value of direction and stick it into another element.
Comment 3 WebKit Commit Bot 2013-11-10 17:56:01 PST 
Comment on attachment 216523 [details]
Patch V1

Clearing flags on attachment: 216523

Committed r159035: <http://trac.webkit.org/changeset/159035>
Comment 4 WebKit Commit Bot 2013-11-10 17:56:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Frédéric Wang (:fredw) 2014-03-10 12:26:17 PDT 
Mass change: add WebExposed keyword to help MDN documentation.