Bug 124460 - Add LineInlineHeaders.h to WebCore.xcodeproj
Summary: Add LineInlineHeaders.h to WebCore.xcodeproj
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 121261
  Show dependency tree / graph
 
Reported: 2013-11-16 12:45 PST by Zoltan Horvath
Modified: 2013-11-19 09:13 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2013-11-16 12:47 PST, Zoltan Horvath 		ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
revision number added to changelog (3.29 KB, patch)
2013-11-19 08:30 PST, Zoltan Horvath 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
updated to tot (2.08 KB, patch)
2013-11-19 08:39 PST, Zoltan Horvath 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
updated to á (2.08 KB, patch)
2013-11-19 08:43 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-11-16 12:45:17 PST 
LineInlineHeaders.h hasn't been added to WebCore.xcodeproj. This patch adds to it.
Comment 1 Zoltan Horvath 2013-11-16 12:47:08 PST 
Created attachment 217131 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-11-19 04:43:12 PST 
Comment on attachment 217131 [details]
Patch

r=me, but you could mention in the changelog it is a followup patch for r159354.
Comment 3 Zoltan Horvath 2013-11-19 08:30:59 PST 
Created attachment 217300 [details]
revision number added to changelog
Comment 4 WebKit Commit Bot 2013-11-19 08:32:05 PST 
Comment on attachment 217300 [details]
revision number added to changelog

Rejecting attachment 217300 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 217300, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 FAILED at 6306.
Hunk #2 FAILED at 13488.
Hunk #3 FAILED at 21911.
Hunk #4 succeeded at 24440 (offset 2 lines).
3 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/28858089
Comment 5 Zoltan Horvath 2013-11-19 08:39:11 PST 
Created attachment 217301 [details]
updated to tot
Comment 6 WebKit Commit Bot 2013-11-19 08:40:28 PST 
Comment on attachment 217301 [details]
updated to tot

Rejecting attachment 217301 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 217301, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Csaba Osztrogonac found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/27428111
Comment 7 Zoltan Horvath 2013-11-19 08:43:36 PST 
Created attachment 217302 [details]
updated to á
Comment 8 WebKit Commit Bot 2013-11-19 09:13:12 PST 
Comment on attachment 217302 [details]
updated to á

Clearing flags on attachment: 217302

Committed r159502: <http://trac.webkit.org/changeset/159502>
Comment 9 WebKit Commit Bot 2013-11-19 09:13:14 PST 
All reviewed patches have been landed.  Closing bug.