Bug 124878 - Avoid unnecessary copy-on-write in FillLayer style application.
Summary: Avoid unnecessary copy-on-write in FillLayer style application.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-25 18:18 PST by Andreas Kling
Modified: 2013-11-26 08:17 PST (History)
7 users (show)

See Also:

Attachments
Patch idea (2.65 KB, patch)
2013-11-25 18:18 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-25 18:18:17 PST 
ApplyPropertyFillLayer always creates a mutable copy of the StyleBackgroundData. Because stupid.
Comment 1 Andreas Kling 2013-11-25 18:18:50 PST 
Created attachment 217855 [details]
Patch idea
Comment 2 Antti Koivisto 2013-11-26 07:50:01 PST 
Comment on attachment 217855 [details]
Patch idea

View in context: https://bugs.webkit.org/attachment.cgi?id=217855&action=review

> Source/WebCore/css/DeprecatedStyleBuilder.cpp:519
> +        if (*(styleResolver->parentStyle()->*layersFunction)() == *(styleResolver->style()->*layersFunction)())

kinda wat
Comment 3 WebKit Commit Bot 2013-11-26 08:17:40 PST 
Comment on attachment 217855 [details]
Patch idea

Clearing flags on attachment: 217855

Committed r159782: <http://trac.webkit.org/changeset/159782>
Comment 4 WebKit Commit Bot 2013-11-26 08:17:44 PST 
All reviewed patches have been landed.  Closing bug.