The JavaScriptCore API headers contain some legacy constructs that could be modernized while preserving binary compatibility. We should do that! <rdar://problem/15540121>
Created attachment 218279 [details] Patch
Attachment 218279 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSManagedValue.h', u'Source/JavaScriptCore/API/JSManagedValue.mm', u'Source/JavaScriptCore/API/JSStringRefCF.h', u'Source/JavaScriptCore/API/JSValue.h', u'Source/JavaScriptCore/API/JSVirtualMachine.h', u'Source/JavaScriptCore/API/JSVirtualMachine.mm', u'Source/JavaScriptCore/ChangeLog']" exit_code: 1 ERROR: Source/JavaScriptCore/API/JSStringRefCF.h:54: The parameter name "alloc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSStringRefCF.h:54: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValue.h:383: Missing spaces around = [whitespace/operators] [4] ERROR: Source/JavaScriptCore/API/JSValue.h:389: Missing spaces around = [whitespace/operators] [4] ERROR: Source/JavaScriptCore/API/JSValue.h:395: Missing spaces around = [whitespace/operators] [4] ERROR: Source/JavaScriptCore/API/JSValue.h:404: Missing spaces around = [whitespace/operators] [4] ERROR: Source/JavaScriptCore/API/JSValue.h:410: Missing spaces around = [whitespace/operators] [4] ERROR: Source/JavaScriptCore/API/JSValue.h:416: Missing spaces around = [whitespace/operators] [4] Total errors found: 8 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
This class of naming looks strange to me: @property (getter=isNumber, readonly) BOOL number; I think of that property as "isNumber", and not "number".
That's the naming convention for properties per <https://developer.apple.com/library/mac/documentation/cocoa/conceptual/codingguidelines/Articles/NamingIvarsAndTypes.html>. I've reached out to some folks internally for guidance on this since it does lead to some awkward constructs (value.number returning a BOOL, for instance). I'll hold off on landing this for now.
Created attachment 218937 [details] Patch
The feedback that I received that in this case following the convention is too confusing, so I'm leaving the isFoo methods as simple getters.
Attachment 218937 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSManagedValue.h', u'Source/JavaScriptCore/API/JSManagedValue.mm', u'Source/JavaScriptCore/API/JSStringRefCF.h', u'Source/JavaScriptCore/API/JSValue.h', u'Source/JavaScriptCore/API/JSVirtualMachine.h', u'Source/JavaScriptCore/API/JSVirtualMachine.mm', u'Source/JavaScriptCore/ChangeLog', '--commit-queue']" exit_code: 1 ERROR: Source/JavaScriptCore/API/JSStringRefCF.h:54: The parameter name "alloc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSStringRefCF.h:54: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 218937 [details] Patch Clearing flags on attachment: 218937 Committed r160454: <http://trac.webkit.org/changeset/160454>
All reviewed patches have been landed. Closing bug.