Bug 126283 - Subpixel layout: Umbrella bug for enabling subpixel layout.
Summary: Subpixel layout: Umbrella bug for enabling subpixel layout.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.9
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
: 102622 (view as bug list)
Depends on: 126651 126898 126900 127524 101848 125659 125673 125728 125757 125829 125911 125963 125977 126008 126646 126647 126650 126653 126656 126657 126658 126663 126664 126665 126844 126892 126899 127074 127212 127404
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-29 21:02 PST by zalan
Modified: 2014-06-27 13:23 PDT (History)
12 users (show)

See Also:

Attachments
regressions on LayoutTests/fast (185.08 KB, text/html)
2013-12-29 21:39 PST, zalan 		no flags Details
LayoutTests/fast results (395.45 KB, text/html)
2014-01-08 19:53 PST, zalan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2013-12-29 21:02:53 PST 
<rdar://problem/15172510>
Comment 1 zalan 2013-12-29 21:39:27 PST 
Created attachment 220099 [details]
regressions on LayoutTests/fast
Comment 2 zalan 2014-01-08 19:53:22 PST 
Created attachment 220694 [details]
LayoutTests/fast results
Comment 3 zalan 2014-01-13 09:12:58 PST 
Committed r161882: <http://trac.webkit.org/changeset/161882>
Comment 4 zalan 2014-01-13 09:13:53 PST 
closed by bot. reopen.
Comment 5 Jon Lee 2014-01-14 00:17:17 PST 
*** Bug 102622 has been marked as a duplicate of this bug. ***
Comment 6 Csaba Osztrogonác 2014-01-14 14:16:44 PST 
(In reply to comment #3)
> Committed r161882: <http://trac.webkit.org/changeset/161882>

Apple Windows bots are dead after this change. Are you plannig 
to update Windows expected files too?

http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29?numbuilds=200
Comment 7 zalan 2014-01-14 15:56:26 PST 
(In reply to comment #6)
> (In reply to comment #3)
> > Committed r161882: <http://trac.webkit.org/changeset/161882>
> 
> Apple Windows bots are dead after this change. Are you plannig 
> to update Windows expected files too?
> 
> http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29?numbuilds=200

I'll be turing off subpixel layout for Win.
Comment 8 Roger Fong 2014-01-15 15:40:43 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #3)
> > > Committed r161882: <http://trac.webkit.org/changeset/161882>
> > 
> > Apple Windows bots are dead after this change. Are you plannig 
> > to update Windows expected files too?
> > 
> > http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29?numbuilds=200
> 
> I'll be turing off subpixel layout for Win.

Are rebaselines for sub pixel layout on Win being worked on?
It'd be nice to have sub pixel layout on for Win, so that we can continue to fall back to mac's expected results and have less failures. Right now the bots are unusable.
Comment 9 zalan 2014-01-15 16:38:11 PST 
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #3)
> > > > Committed r161882: <http://trac.webkit.org/changeset/161882>
> > > 
> > > Apple Windows bots are dead after this change. Are you plannig 
> > > to update Windows expected files too?
> > > 
> > > http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29?numbuilds=200
> > 
> > I'll be turing off subpixel layout for Win.
> 
> Are rebaselines for sub pixel layout on Win being worked on?
> It'd be nice to have sub pixel layout on for Win, so that we can continue to fall back to mac's expected results and have less failures. Right now the bots are unusable.
This and a bit of a rebaseline should help.
https://bugs.webkit.org/show_bug.cgi?id=127074
Comment 10 zalan 2014-01-19 18:17:34 PST 
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > (In reply to comment #3)
> > > > > Committed r161882: <http://trac.webkit.org/changeset/161882>
> > > > 
> > > > Apple Windows bots are dead after this change. Are you plannig 
> > > > to update Windows expected files too?
> > > > 
> > > > http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29?numbuilds=200
> > > 
> > > I'll be turing off subpixel layout for Win.
> > 
> > Are rebaselines for sub pixel layout on Win being worked on?
> > It'd be nice to have sub pixel layout on for Win, so that we can continue to fall back to mac's expected results and have less failures. Right now the bots are unusable.
> This and a bit of a rebaseline should help.
> https://bugs.webkit.org/show_bug.cgi?id=127074
Win should be all set now.