Bug 126367 - RenderScrollbar: Map of scrollbar parts should use RenderPtr.
Summary: RenderScrollbar: Map of scrollbar parts should use RenderPtr.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 16:01 PST by Andreas Kling
Modified: 2014-01-01 16:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.77 KB, patch)
2014-01-01 16:29 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-01-01 16:01:39 PST 
RenderScrollbar: Map of scrollbar parts should use RenderPtr.
Comment 1 Andreas Kling 2014-01-01 16:29:28 PST 
Created attachment 220197 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-01 16:30:12 PST 
Attachment 220197 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderPtr.h', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbar.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/rendering/RenderScrollbar.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2014-01-01 16:39:15 PST 
Comment on attachment 220197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220197&action=review

> Source/WebCore/rendering/RenderPtr.h:165
> +template<typename T> struct HashTraits<WebCore::RenderPtr<T>> : SimpleClassHashTraits<WebCore::RenderPtr<T>> {

Might be nice to have SmartPointerHashTraits in WTF to make these copy-pastes smaller.
Comment 4 Andreas Kling 2014-01-01 16:49:17 PST 
Committed r161200: <http://trac.webkit.org/changeset/161200>