Bug 126513 - RenderBlock::clone() should return RenderPtr.
Summary: RenderBlock::clone() should return RenderPtr.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 00:36 PST by Andreas Kling
Modified: 2014-01-06 02:35 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2014-01-06 00:40 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-01-06 00:36:12 PST
RenderBlock::clone() should return RenderPtr.
Comment 1 Andreas Kling 2014-01-06 00:40:31 PST
Created attachment 220417 [details]
Patch
Comment 2 Antti Koivisto 2014-01-06 01:13:33 PST
Comment on attachment 220417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220417&action=review

> Source/WebCore/rendering/RenderBlock.cpp:515
> +        RenderPtr<RenderElement> cloneRenderer = element()->createElementRenderer(style());
> +        cloneBlock = RenderPtr<RenderBlock>(toRenderBlock(cloneRenderer.leakPtr()));

:(
Comment 3 Andreas Kling 2014-01-06 02:35:57 PST
Committed r161337: <http://trac.webkit.org/changeset/161337>