Bug 126560 - [Mac] Fix incorrectness in use of some AppKit enums
Summary: [Mac] Fix incorrectness in use of some AppKit enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 19:09 PST by Mark Rowe (bdash)
Modified: 2014-01-06 19:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2014-01-06 19:13 PST, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-01-06 19:09:09 PST 
There are places in DumpRenderTree and WebKitTestRunner where we work with AppKit enums incorrectly. We do a switch over NSScrollerPart but only handle one case, and we pass an integer to a function that expects NSBackingStoreType without a cast.
Comment 1 Mark Rowe (bdash) 2014-01-06 19:13:36 PST 
Created attachment 220482 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-06 19:56:37 PST 
Comment on attachment 220482 [details]
Patch

Clearing flags on attachment: 220482

Committed r161396: <http://trac.webkit.org/changeset/161396>
Comment 3 WebKit Commit Bot 2014-01-06 19:56:38 PST 
All reviewed patches have been landed.  Closing bug.