Bug 126982 - Pack ResourceRequest harder.
Summary: Pack ResourceRequest harder.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 06:32 PST by Andreas Kling
Modified: 2014-01-17 06:27 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.35 KB, patch)
2014-01-14 06:32 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2014-01-14 06:33 PST, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (2.37 KB, patch)
2014-01-14 08:10 PST, Andreas Kling 		andersca: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-01-14 06:32:21 PST 
Pack ResourceRequest harder.
Comment 1 Andreas Kling 2014-01-14 06:32:51 PST 
Created attachment 221155 [details]
Patch
Comment 2 Andreas Kling 2014-01-14 06:33:15 PST 
Created attachment 221156 [details]
Patch
Comment 3 EFL EWS Bot 2014-01-14 06:40:25 PST 
Comment on attachment 221156 [details]
Patch

Attachment 221156 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5682728406089728
Comment 4 EFL EWS Bot 2014-01-14 06:40:56 PST 
Comment on attachment 221156 [details]
Patch

Attachment 221156 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5781445813469184
Comment 5 Antti Koivisto 2014-01-14 07:05:57 PST 
Comment on attachment 221156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221156&action=review

> Source/WebCore/platform/network/ResourceRequestBase.h:202
> +        ResourceRequestCachePolicy m_cachePolicy : 3;
>          bool m_allowCookies : 1;
>          mutable bool m_resourceRequestUpdated : 1;

You probably need to change all these to unsigned
Comment 6 Andreas Kling 2014-01-14 08:10:57 PST 
Created attachment 221164 [details]
Patch
Comment 7 EFL EWS Bot 2014-01-14 09:06:00 PST 
Comment on attachment 221164 [details]
Patch

Attachment 221164 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5709719993843712
Comment 8 Andreas Kling 2014-01-17 06:27:47 PST 
Committed r162200: <http://trac.webkit.org/changeset/162200>