The selector profiler was painting a mostly fictional picture of what selectors we were spending time on. It never really grokked the fast path selectors, nor did it understand recent additions like the extra cascading pass or the selector JIT. Somewhat ironically, this may end up making some selectors run faster since it removes a number of brances in hot code. FWIW, Blink removed theirs here <https://codereview.chromium.org/21049007>
<rdar://problem/15823608>
Created attachment 221253 [details] Patch
Created attachment 221255 [details] Patch with removed files
Comment on attachment 221255 [details] Patch with removed files Selector profiles are somewhere between useless and actively harmful unless you know a ton about engine internals. Removal is a good idea.
Sounds good. I never liked it either.
Comment on attachment 221255 [details] Patch with removed files View in context: https://bugs.webkit.org/attachment.cgi?id=221255&action=review > Source/WebInspectorUI/UserInterface/CSSSelectorProfileType.js:-61 > - return WebInspector.UIString("CSS selector profiles show how long the selector matching has taken in total and how many times a certain selector has matched DOM elements (the results are approximate due to matching algorithm optimizations.)"); Nit: This patch removes localized strings but does not update localizedStrings.js. To automatically update the localized strings you can run: shell> ./Tools/Scripts/extract-localizable-js-strings ./Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js ./Source/WebInspectorUI/UserInterface There is a basic script you can run, something like ./Tools/Scripts/update-localizable-strings, but the command above just targets WebInspectorUI strings and takes ~1 second. I'll update the strings now. Good job on this removal! I think you covered everything!
(In reply to comment #6) > I'll update the strings now. Actually, this hasn't landed yet! So there is time for you to update the strings =)
Committed r162084: <http://trac.webkit.org/changeset/162084>