Bug 129131 - DefaultGCActivityCallback::doWork() should reschedule if GC is deferred
Summary: DefaultGCActivityCallback::doWork() should reschedule if GC is deferred
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-20 17:17 PST by Mark Lam
Modified: 2014-02-20 18:48 PST (History)
6 users (show)

See Also:

Attachments
the patch (1.70 KB, patch)
2014-02-20 18:02 PST, Mark Lam 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-02-20 17:17:22 PST 
Currently, DefaultGCActivityCallback::doWork() does not check if the GC needs to be deferred before commencing.  Will fix.

ref: <rdar://problem/15447622>
Comment 1 Mark Lam 2014-02-20 18:02:24 PST 
Created attachment 224815 [details]
the patch
Comment 2 Mark Hahnenberg 2014-02-20 18:04:43 PST 
Comment on attachment 224815 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224815&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +        supposed to be deferred and re-schedule if needed. It only commences with

reschedules
Comment 3 Mark Lam 2014-02-20 18:48:37 PST 
Thanks.  Landed in r164463: <http://trac.webkit.org/r164463>.