Bug 129582 - Clean up use of Options::enableConcurrentJIT().
Summary: Clean up use of Options::enableConcurrentJIT().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-02 14:15 PST by Mark Lam
Modified: 2014-03-02 15:09 PST (History)
7 users (show)

See Also:

Attachments
the patch. (2.79 KB, patch)
2014-03-02 14:28 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-03-02 14:15:12 PST 
DFG Driver was conditionally checking Options::enableConcurrentJIT() only if ENABLE(CONCURRENT_JIT).  Otherwise, it bypasses it with a local enableConcurrentJIT set to false.

Instead we should configure Options::enableConcurrentJIT() to be false in Options.cpp if !ENABLE(CONCURRENT_JIT), and DFG Driver should always check Options::enableConcurrentJIT().  This makes the code read a little cleaner.
Comment 1 Mark Lam 2014-03-02 14:28:21 PST 
Created attachment 225611 [details]
the patch.
Comment 2 WebKit Commit Bot 2014-03-02 15:09:11 PST 
Comment on attachment 225611 [details]
the patch.

Clearing flags on attachment: 225611

Committed r164953: <http://trac.webkit.org/changeset/164953>
Comment 3 WebKit Commit Bot 2014-03-02 15:09:15 PST 
All reviewed patches have been landed.  Closing bug.