Bug 129720 - Streamline JSValue::get().
Summary: Streamline JSValue::get().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 17:54 PST by Andreas Kling
Modified: 2014-03-04 18:29 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.11 KB, patch)
2014-03-04 17:56 PST, Andreas Kling
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-04 17:54:44 PST
Streamline JSValue::get() to avoid fetching Structure and VM repeatedly.
Comment 1 Andreas Kling 2014-03-04 17:56:08 PST
Created attachment 225834 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-04 18:09:23 PST
Comment on attachment 225834 [details]
Patch

Can you make vm and structure arguments 2 and 3, instead of the last two arguments? The last argument is the output, and I'd like to distinguish the input values from the output value.
Comment 3 Andreas Kling 2014-03-04 18:29:35 PST
Committed r165090: <http://trac.webkit.org/changeset/165090>