Bug 129790 - [Mac] Always do a full GC when simulating memory pressure.
Summary: [Mac] Always do a full GC when simulating memory pressure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 01:31 PST by Andreas Kling
Modified: 2014-04-08 13:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2014-03-06 01:36 PST, Andreas Kling 		ggaren: review-
Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2014-04-08 12:03 PDT, Andreas Kling 		ggaren: review-
Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2014-04-08 12:45 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-06 01:31:24 PST 
We should call releaseExecutableMemory() when under memory pressure.
Comment 1 Andreas Kling 2014-03-06 01:36:42 PST 
Created attachment 225967 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-06 09:41:42 PST 
Comment on attachment 225967 [details]
Patch

I don't think we can afford to do this :(. The cost of GC under memory pressure is just too high.

Can we throw away code without forcing a GC?
Comment 3 Andreas Kling 2014-04-08 12:03:45 PDT 
Created attachment 228864 [details]
Patch
Comment 4 Geoffrey Garen 2014-04-08 12:29:26 PDT 
Comment on attachment 228864 [details]
Patch

/Volumes/Data/EWS/WebKit/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:76:9: error: use of undeclared identifier 'gcController'
        gcController().garbageCollectNow();
        ^
Comment 5 Andreas Kling 2014-04-08 12:45:33 PDT 
Created attachment 228871 [details]
Patch
Comment 6 Geoffrey Garen 2014-04-08 12:46:36 PDT 
Comment on attachment 228871 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2014-04-08 13:27:20 PDT 
Comment on attachment 228871 [details]
Patch

Clearing flags on attachment: 228871

Committed r166953: <http://trac.webkit.org/changeset/166953>
Comment 8 WebKit Commit Bot 2014-04-08 13:27:23 PDT 
All reviewed patches have been landed.  Closing bug.