Bug 129984 - Inline the trivial parts of GC deferral.
Summary: Inline the trivial parts of GC deferral.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 18:02 PST by Andreas Kling
Modified: 2014-03-09 18:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2014-03-08 18:03 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-08 18:02:05 PST 
DYEB spends about 1.5% in DeferGC. Inlining everything but collect() looks like a 1% progression on my MBP.
Comment 1 Andreas Kling 2014-03-08 18:03:05 PST 
Created attachment 226243 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-09 12:24:05 PDT 
Comment on attachment 226243 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-09 14:01:43 PDT 
Comment on attachment 226243 [details]
Patch

Clearing flags on attachment: 226243

Committed r165355: <http://trac.webkit.org/changeset/165355>
Comment 4 WebKit Commit Bot 2014-03-09 14:01:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2014-03-09 18:00:46 PDT 
One test crashing (in thread 2043!) after this:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r165356%20(13132)/results.html
Comment 6 Andreas Kling 2014-03-09 18:41:59 PDT 
(In reply to comment #5)
> One test crashing (in thread 2043!) after this:
> http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r165356%20(13132)/results.html

AFAICT that was crashing prior to this change, too.