Bug 130065 - r165414 broke the 32-bit x86 tests: ASSERTION FAILED: result != InvalidIndex @ GPRInfo.h:330
Summary: r165414 broke the 32-bit x86 tests: ASSERTION FAILED: result != InvalidIndex ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-10 19:56 PDT by Mark Lam
Modified: 2014-03-10 21:48 PDT (History)
8 users (show)

See Also:


Attachments
the patch. (3.25 KB, patch)
2014-03-10 21:15 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-03-10 19:56:43 PDT
The assertion failure shows up readily when you run "run-javascriptcore-tests --debug --32-bit".
Comment 1 Filip Pizlo 2014-03-10 19:59:00 PDT
Looking at it.
Comment 2 Mark Lam 2014-03-10 21:08:07 PDT
<rdar://problem/16284986>
Comment 3 Mark Lam 2014-03-10 21:11:07 PDT
There is code in ScratchRegisterAllocator.cpp that is expecting GPRInfo::toIndex() to be able to return InvalidIndex.  Hence, the assertion is invalid.  Ditto for FPRInfo::toIndex().

The fix is to remove the "result != InvalidIndex" assertions.
Comment 4 Mark Lam 2014-03-10 21:15:15 PDT
Created attachment 226381 [details]
the patch.
Comment 5 Mark Lam 2014-03-10 21:20:08 PDT
Comment on attachment 226381 [details]
the patch.

Thanks for the review.
Comment 6 Filip Pizlo 2014-03-10 21:24:22 PDT
Comment on attachment 226381 [details]
the patch.

r=me too
Comment 7 WebKit Commit Bot 2014-03-10 21:48:00 PDT
Comment on attachment 226381 [details]
the patch.

Clearing flags on attachment: 226381

Committed r165431: <http://trac.webkit.org/changeset/165431>
Comment 8 WebKit Commit Bot 2014-03-10 21:48:03 PDT
All reviewed patches have been landed.  Closing bug.