Bug 130143 - Network process instantiates JSC::VM under fake memory pressure.
Summary: Network process instantiates JSC::VM under fake memory pressure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 11:08 PDT by Andreas Kling
Modified: 2014-03-13 19:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2014-03-12 11:09 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-12 11:08:37 PDT 
D'oh. The fake memory pressure handler calls GCController::garbageCollectSoon() which causes instantiation of a JSC::VM.
This is never needed in the network process, and the pressure relief code already kicks the report-abandoned-object-graph chicken.
Comment 1 Andreas Kling 2014-03-12 11:09:32 PDT 
Created attachment 226535 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-12 11:14:21 PDT 
Comment on attachment 226535 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-13 19:14:42 PDT 
Comment on attachment 226535 [details]
Patch

Clearing flags on attachment: 226535

Committed r165592: <http://trac.webkit.org/changeset/165592>
Comment 4 WebKit Commit Bot 2014-03-13 19:14:44 PDT 
All reviewed patches have been landed.  Closing bug.