Remove all uses of deprecatedCharacters from JavaScriptCore
Created attachment 226842 [details] Patch
Comment on attachment 226842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226842&action=review > Source/JavaScriptCore/API/JSValueRef.cpp:336 > + if (str.is8Bit()) { I think this will crash if str is a null string.
Created attachment 226843 [details] Patch
Committed r165703: <http://trac.webkit.org/changeset/165703>
Looks like this broke JSC tests on bots: 1 0x109b29a9e WTF::StringImpl::destroy(WTF::StringImpl*) 2 0x10998ea0c JSStringRelease 3 0x10999fa31 -[JSValue valueForProperty:] 4 0x109725741 __testObjectiveCAPI_block_invoke354 5 0x10994b45d -[JSContext(Internal) valueFromNotifyException:] 6 0x10994abba -[JSContext evaluateScript:withSourceURL:] 7 0x10971ebe2 testObjectiveCAPI 8 0x10971651c main 9 0x7fff8b5645fd start 10 0x1
(In reply to comment #5) > Looks like this broke JSC tests on bots: > > 1 0x109b29a9e WTF::StringImpl::destroy(WTF::StringImpl*) > 2 0x10998ea0c JSStringRelease > 3 0x10999fa31 -[JSValue valueForProperty:] > 4 0x109725741 __testObjectiveCAPI_block_invoke354 > 5 0x10994b45d -[JSContext(Internal) valueFromNotifyException:] > 6 0x10994abba -[JSContext evaluateScript:withSourceURL:] > 7 0x10971ebe2 testObjectiveCAPI > 8 0x10971651c main > 9 0x7fff8b5645fd start > 10 0x1 Fixed this in <http://trac.webkit.org/r165719>. Not sure why webkit-patch added an r=andersca.
Thanks Andreas, for fixing my mistake. Maybe someone who understands the rationale should add a comment explaining why we go out of our way to make a new string instead of using the existing one.