Bug 130479 - [Mac] Support asynchronous NSTextInputClient
Summary: [Mac] Support asynchronous NSTextInputClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-19 14:47 PDT by Alexey Proskuryakov
Modified: 2014-03-20 10:45 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (90.00 KB, patch)
2014-03-19 16:14 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
updated to ToT (90.13 KB, patch)
2014-03-19 16:23 PDT, Alexey Proskuryakov 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-19 14:47:02 PDT 
NSTextInputClient calls are a huge source of sync calls from UIProcess to WebProcess, which is bad. Add support for handling them asynchronously.
Comment 1 Alexey Proskuryakov 2014-03-19 16:14:21 PDT 
Created attachment 227228 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2014-03-19 16:23:56 PDT 
Created attachment 227229 [details]
updated to ToT
Comment 3 WebKit Commit Bot 2014-03-19 16:26:38 PDT 
Attachment 227229 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3980:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alexey Proskuryakov 2014-03-20 10:45:41 PDT 
Committed <http://trac.webkit.org/r165972>.