Bug 130545 - Less inclusion of JSCInlines.h.
Summary: Less inclusion of JSCInlines.h.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 16:49 PDT by Andreas Kling
Modified: 2014-03-21 12:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.14 KB, patch)
2014-03-20 16:50 PDT, Andreas Kling
simon.fraser: review+
Details | Formatted Diff | Diff
Patch fo' landing (8.13 KB, patch)
2014-03-21 10:46 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch fo' landing #2 (8.70 KB, patch)
2014-03-21 11:33 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-20 16:49:41 PDT
Less inclusion of JSCInlines.h.
Comment 1 Andreas Kling 2014-03-20 16:50:31 PDT
Created attachment 227354 [details]
Patch
Comment 2 Andreas Kling 2014-03-20 16:51:19 PDT
After this change, WebCore no longer depends on DFG headers.
Comment 3 Simon Fraser (smfr) 2014-03-20 18:10:43 PDT
The two inline patches reduced build time by 7% for me (30 -> 28mins)
Comment 4 Andreas Kling 2014-03-21 10:46:10 PDT
Created attachment 227455 [details]
Patch fo' landing
Comment 5 Andreas Kling 2014-03-21 11:33:38 PDT
Created attachment 227466 [details]
Patch fo' landing #2
Comment 6 Andreas Kling 2014-03-21 12:18:25 PDT
Committed r166091: <http://trac.webkit.org/changeset/166091>