Bug 130566 - StackLayoutPhase should find the union'ed calleeVariable before accessing its machineLocal
Summary: StackLayoutPhase should find the union'ed calleeVariable before accessing its...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-20 22:58 PDT by Mark Lam
Modified: 2014-03-21 09:07 PDT (History)
2 users (show)

See Also:

Attachments
the patch. (4.09 KB, patch)
2014-03-20 23:44 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-03-20 22:58:12 PDT 
Patch coming.
Comment 1 Mark Lam 2014-03-20 22:59:06 PDT 
<rdar://problem/16386914>
Comment 2 Mark Lam 2014-03-20 23:44:40 PDT 
Created attachment 227388 [details]
the patch.
Comment 3 Mark Lam 2014-03-21 08:04:51 PDT 
Comment on attachment 227388 [details]
the patch.

Thanks for the review.
Comment 4 Mark Lam 2014-03-21 08:29:30 PDT 
Comment on attachment 227388 [details]
the patch.

There appear to be some discrepancy with the layout test results.  Will rerun the test to confirm that the results are correct.
Comment 5 Mark Lam 2014-03-21 09:00:16 PDT 
The issue is that DumpRenderTree renders 2 consecutive spaces in the test description string as 1 space while jsc renders it literally as 2.  I fixed this by only using 1 space in the test description string.  Preparing to land the patch.
Comment 6 Mark Lam 2014-03-21 09:07:14 PDT 
Comment on attachment 227388 [details]
the patch.

Clearing flags.  Patch landed in r166064: <http://trac.webkit.org/r166064>.