Bug 130648 - CREATE_DOM_WRAPPER doesn't need the ExecState.
Summary: CREATE_DOM_WRAPPER doesn't need the ExecState.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-22 16:33 PDT by Andreas Kling
Modified: 2014-03-22 17:35 PDT (History)
13 users (show)

See Also:

Attachments
Patch (47.12 KB, patch)
2014-03-22 16:36 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (48.21 KB, patch)
2014-03-22 17:21 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-22 16:33:49 PDT 
CREATE_DOM_WRAPPER doesn't need the JSC::ExecState. The global object should have everything we need.
Comment 1 Andreas Kling 2014-03-22 16:36:19 PDT 
Created attachment 227578 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-22 16:37:57 PDT 
Attachment 227578 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:211:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-03-22 16:42:34 PDT 
Comment on attachment 227578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227578&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:211
> +template<class WrapperClass, class DOMClass> inline JSC::JSValue wrap( JSDOMGlobalObject* globalObject, DOMClass* domObject)

Extra space left here before JSDOMGlobalObject
Comment 4 Andreas Kling 2014-03-22 17:21:27 PDT 
Created attachment 227584 [details]
Patch for landing
Comment 5 Andreas Kling 2014-03-22 17:35:52 PDT 
Committed r166128: <http://trac.webkit.org/changeset/166128>