The lockHistory and lockBackForwardList arguments are often passed using literals at the call site. Using multiple consecutive boolean arguments makes it hard to keep track of which is which.
Created attachment 228437 [details] Patch
Attachment 228437 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FormSubmission.h:92: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/FrameLoader.h:110: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 228444 [details] Patch
Attachment 228444 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FormSubmission.h:92: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/FrameLoader.h:110: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228444 [details] Patch OK, r=me
Comment on attachment 228444 [details] Patch Clearing flags on attachment: 228444 Committed r166684: <http://trac.webkit.org/changeset/166684>
All reviewed patches have been landed. Closing bug.