Bug 131653 - [iOS WebKit2] Listen for system memory pressure notifications.
Summary: [iOS WebKit2] Listen for system memory pressure notifications.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-14 18:01 PDT by Andreas Kling
Modified: 2014-04-15 17:02 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.17 KB, patch)
2014-04-15 10:43 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2014-04-15 10:53 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (4.38 KB, patch)
2014-04-15 13:10 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2014-04-15 13:10 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-04-14 18:01:38 PDT
<rdar://problem/16208123>
Comment 1 Andreas Kling 2014-04-15 10:43:22 PDT
Created attachment 229377 [details]
Patch
Comment 2 Pratik Solanki 2014-04-15 10:48:36 PDT
Comment on attachment 229377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229377&action=review

> Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm:77
> +#elif MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

Make this PLATFORM(MAC) && MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 otherwise iOS 7.1 compiles will likely fail.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1076
> +//        return GestureType::PhraseBoundary;

Stray changes.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1115
> +  //      return UIWKGesturePhraseBoundary;

More stray changes.
Comment 3 Andreas Kling 2014-04-15 10:53:44 PDT
Created attachment 229378 [details]
Patch
Comment 4 Andreas Kling 2014-04-15 13:10:03 PDT
Created attachment 229395 [details]
Patch
Comment 5 Andreas Kling 2014-04-15 13:10:52 PDT
Created attachment 229396 [details]
Patch
Comment 6 WebKit Commit Bot 2014-04-15 17:02:00 PDT
Comment on attachment 229396 [details]
Patch

Clearing flags on attachment: 229396

Committed r167338: <http://trac.webkit.org/changeset/167338>
Comment 7 WebKit Commit Bot 2014-04-15 17:02:03 PDT
All reviewed patches have been landed.  Closing bug.