Bug 132976 - [Mac] Move discovery of sharing services off the main thread
Summary: [Mac] Move discovery of sharing services off the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-15 16:56 PDT by Mark Rowe (bdash)
Modified: 2014-05-15 17:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.90 KB, patch)
2014-05-15 17:01 PDT, Mark Rowe (bdash)
beidson: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-05-15 16:56:19 PDT
Discovering sharing services isn't a particularly cheap operation, requiring disk access and even IPC. Since the discovery is already asynchronous and we've been told the API we're using can be safely used from a background thread, we should move it off the main thread.
Comment 1 Mark Rowe (bdash) 2014-05-15 17:01:22 PDT
Created attachment 231543 [details]
Patch
Comment 2 Brady Eidson 2014-05-15 17:08:21 PDT
Comment on attachment 231543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231543&action=review

> Source/WebKit2/UIProcess/mac/ServicesController.mm:82
> +    NSLog(@"+ServicesController::refreshExistingServices");

No.

> Source/WebKit2/UIProcess/mac/ServicesController.mm:110
> +            NSLog(@"-ServicesController::refreshExistingServices");

No.
Comment 3 Mark Rowe (bdash) 2014-05-15 17:15:55 PDT
Landed in <http://trac.webkit.org/changeset/168918>.