WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132976
[Mac] Move discovery of sharing services off the main thread
https://bugs.webkit.org/show_bug.cgi?id=132976
Summary
[Mac] Move discovery of sharing services off the main thread
Mark Rowe (bdash)
Reported
2014-05-15 16:56:19 PDT
Discovering sharing services isn't a particularly cheap operation, requiring disk access and even IPC. Since the discovery is already asynchronous and we've been told the API we're using can be safely used from a background thread, we should move it off the main thread.
Attachments
Patch
(5.90 KB, patch)
2014-05-15 17:01 PDT
,
Mark Rowe (bdash)
beidson
: review+
beidson
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2014-05-15 17:01:22 PDT
Created
attachment 231543
[details]
Patch
Brady Eidson
Comment 2
2014-05-15 17:08:21 PDT
Comment on
attachment 231543
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231543&action=review
> Source/WebKit2/UIProcess/mac/ServicesController.mm:82 > + NSLog(@"+ServicesController::refreshExistingServices");
No.
> Source/WebKit2/UIProcess/mac/ServicesController.mm:110 > + NSLog(@"-ServicesController::refreshExistingServices");
No.
Mark Rowe (bdash)
Comment 3
2014-05-15 17:15:55 PDT
Landed in <
http://trac.webkit.org/changeset/168918
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug