Bug 133038 - We shouldn't make a ScrollingThread on iOS.
Summary: We shouldn't make a ScrollingThread on iOS.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
: 133037 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-17 18:05 PDT by Andreas Kling
Modified: 2014-07-03 23:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2014-05-17 18:07 PDT, Andreas Kling 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-05-17 18:05:23 PDT 
<rdar://problem/16947589>
Comment 1 Andreas Kling 2014-05-17 18:07:29 PDT 
Created attachment 231643 [details]
Patch
Comment 2 Sam Weinig 2014-05-17 18:57:49 PDT 
Comment on attachment 231643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231643&action=review

> Source/WebCore/ChangeLog:10
> +        * platform/MemoryPressureHandler.cpp:
> +        (WebCore::MemoryPressureHandler::releaseMemory):

This could use some explanation.  I assume this is the only place where we dispatch the to the scrolling thread still?  Perhaps we should have a proper ENABLE() for this and compile out all the ScrollingThread code.
Comment 3 Andreas Kling 2014-05-17 19:05:57 PDT 
Committed r169004: <http://trac.webkit.org/changeset/169004>
Comment 4 Tim Horton 2014-05-18 20:23:31 PDT 
This doesn't seem like the right fix. What if we have UI-side compositing turned on on Mac?
Comment 5 Andreas Kling 2014-07-03 23:46:23 PDT 
*** Bug 133037 has been marked as a duplicate of this bug. ***