Bug 133671 - [iOS WebKit2] Stay in "memory pressure" mode until told otherwise.
Summary: [iOS WebKit2] Stay in "memory pressure" mode until told otherwise.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 19:52 PDT by Andreas Kling
Modified: 2014-06-10 09:30 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.08 KB, patch)
2014-06-09 19:53 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-06-09 19:52:13 PDT
After receiving a memory pressure notification, we should stay on alert until the system tells us bad times are over.
Comment 1 Andreas Kling 2014-06-09 19:53:02 PDT
Created attachment 232764 [details]
Patch
Comment 2 Sam Weinig 2014-06-09 22:24:18 PDT
Comment on attachment 232764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232764&action=review

> Source/WebCore/platform/MemoryPressureHandler.h:111
> +    void respondToMemoryPressure(bool critical);

This seems like a good place for an enum.
Comment 3 WebKit Commit Bot 2014-06-10 09:02:35 PDT
Comment on attachment 232764 [details]
Patch

Clearing flags on attachment: 232764

Committed r169746: <http://trac.webkit.org/changeset/169746>
Comment 4 WebKit Commit Bot 2014-06-10 09:02:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Tim Horton 2014-06-10 09:30:48 PDT
Comment on attachment 232764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232764&action=review

> Source/WebCore/ChangeLog:17
> +        Also propagate the "critical" flag all the way from the system
> +        to the pressure handler. Note that we don't actually do anything
> +        differently based on the flag yet.

yay!