Bug 133739 - Some JSValue::get() micro-optimizations.
Summary: Some JSValue::get() micro-optimizations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-11 08:54 PDT by Andreas Kling
Modified: 2014-06-11 12:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.12 KB, patch)
2014-06-11 08:54 PDT, Andreas Kling
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-06-11 08:54:18 PDT
More hax to make GetByVal do less work.
Comment 1 Andreas Kling 2014-06-11 08:54:58 PDT
Created attachment 232868 [details]
Patch
Comment 2 Ryosuke Niwa 2014-06-11 09:32:00 PDT
Also see https://bugs.webkit.org/show_bug.cgi?id=133727
Comment 3 Geoffrey Garen 2014-06-11 11:29:44 PDT
Comment on attachment 232868 [details]
Patch

r=me
Comment 4 Andreas Kling 2014-06-11 11:40:47 PDT
Committed r169815: <http://trac.webkit.org/changeset/169815>
Comment 5 Ryosuke Niwa 2014-06-11 11:43:20 PDT
(In reply to comment #4)
> Committed r169815: <http://trac.webkit.org/changeset/169815>

Could you be able to tell us how much improvement you saw on https://bug-133727-attachments.webkit.org/attachment.cgi?id=232853 ?
Comment 6 Andreas Kling 2014-06-11 12:07:27 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Committed r169815: <http://trac.webkit.org/changeset/169815>
> 
> Could you be able to tell us how much improvement you saw on https://bug-133727-attachments.webkit.org/attachment.cgi?id=232853 ?

Two samples:

55.15ms -> 46.78ms
54.52ms -> 46.64ms