There should only be one.
Created attachment 233874 [details] the patch.
Comment on attachment 233874 [details] the patch. Attachment 233874 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5677282639216640 New failing tests: editing/selection/4895428-2.html accessibility/axpress-on-aria-button.html editing/pasteboard/can-read-in-dragstart-event.html editing/selection/4776665.html animations/suspend-resume-animation-events.html animations/fill-mode-forwards2.html editing/execCommand/paste-and-match-style-event.html editing/input/set-value-on-input-and-delete.html accessibility/label-element-press.html accessibility/aria-activedescendant-crash.html css3/flexbox/relayout-image-load.html compositing/regions/video-in-overflow-region.html http/tests/cache/display-image-unset-allows-cached-image-load.html editing/pasteboard/can-read-in-copy-and-cut-events.html editing/execCommand/paste-1.html http/tests/cache/cancel-during-revalidation-succeeded.html editing/spelling/spellcheck-async-remove-frame.html editing/spelling/design-mode-spellcheck-off.html http/tests/cache/post-with-cached-subresources.php accessibility/media-element.html editing/input/set-value-on-input-and-forward-delete.html animations/fill-mode-forwards.html editing/style/iframe-onload-crash-mac.html accessibility/aria-hidden-false-works-in-subtrees.html compositing/iframes/layout-on-compositing-change.html compositing/video/video-poster.html compositing/iframes/iframe-position-absolute-with-padding-percentage-crash.html http/tests/cache/post-redirect-get.php editing/apply-style-iframe-crash.html http/tests/cache/preload-cleared-after-parsing-canceled-by-js.html
Created attachment 233882 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 233874 [details] the patch. Attachment 233874 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5655709555359744 New failing tests: editing/selection/4895428-2.html compositing/iframes/iframe-position-absolute-with-padding-percentage-crash.html accessibility/axpress-on-aria-button.html editing/pasteboard/can-read-in-dragstart-event.html editing/selection/4776665.html animations/suspend-resume-animation-events.html animations/fill-mode-forwards2.html editing/execCommand/paste-and-match-style-event.html editing/input/set-value-on-input-and-delete.html accessibility/label-element-press.html accessibility/aria-activedescendant-crash.html css3/flexbox/relayout-image-load.html compositing/regions/video-in-overflow-region.html http/tests/cache/display-image-unset-allows-cached-image-load.html editing/pasteboard/can-read-in-copy-and-cut-events.html editing/execCommand/paste-1.html http/tests/cache/cancel-during-revalidation-succeeded.html accessibility/aria-hidden-false-works-in-subtrees.html http/tests/cache/post-with-cached-subresources.php accessibility/media-element.html editing/input/set-value-on-input-and-forward-delete.html animations/fill-mode-forwards.html editing/style/iframe-onload-crash-mac.html editing/execCommand/remove-format-textdecoration-in-iframe.html compositing/iframes/layout-on-compositing-change.html compositing/video/video-poster.html http/tests/cache/reload-main-resource.php http/tests/cache/post-redirect-get.php editing/apply-style-iframe-crash.html http/tests/cache/preload-cleared-after-parsing-canceled-by-js.html
Created attachment 233901 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 233874 [details] the patch. Will check test failures.
Comment on attachment 233874 [details] the patch. I think we need with scope to be per-global-object rather than per-VM so that you can get the global object from the scope. So, the right thing to delete is the per-VM with scope structure.
(In reply to comment #7) > (From update of attachment 233874 [details]) > I think we need with scope to be per-global-object rather than per-VM so that you can get the global object from the scope. So, the right thing to delete is the per-VM with scope structure. Thanks. My debugging and study of the code just got me to the same conclusion. Will fix.
Created attachment 233920 [details] patch 2
Thanks. Landed in r170489: <http://trac.webkit.org/r170489>.