Bug 134362 - Skip memcmp()ing fully downloaded resources after they become mmap()able.
Summary: Skip memcmp()ing fully downloaded resources after they become mmap()able.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-26 14:43 PDT by Andreas Kling
Modified: 2014-06-26 23:05 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2014-06-26 14:44 PDT, Andreas Kling 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-06-26 14:43:02 PDT 
CachedResource::tryReplaceEncodedData() does a memcmp() to check that the data being replaced is exactly equal to the disk-cached version.
This is always the case, and we're wasting a bunch of time doing these comparisons. Let's turn them into assertions.
Comment 1 Andreas Kling 2014-06-26 14:44:37 PDT 
Created attachment 233936 [details]
Patch
Comment 2 Geoffrey Garen 2014-06-26 14:55:59 PDT 
Comment on attachment 233936 [details]
Patch

r=me
Comment 3 Andreas Kling 2014-06-26 15:23:07 PDT 
Committed r170499: <http://trac.webkit.org/changeset/170499>